Skip to content

[8.x] Skip region validation in S3BlobStoreRepositoryTests (#127372) #127381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

[8.x] Skip region validation in S3BlobStoreRepositoryTests (#127372) #127381

merged 2 commits into from
Apr 28, 2025

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Apr 25, 2025 •
edited by nicktindall
Loading

Backports the following commits to 8.x:

Closes #127447
Closes #127448

@DaveCTurner
Skip region validation in S3BlobStoreRepositoryTests (elastic#127372)
9ee1e23 
Today these tests assert that the requests received by the handler are
signed in region `us-east-1` with no region specified, but in fact when
running in EC2 the SDK will pick up the actual region which may be
different. This commit skips this region validation for now (it is
tested elsewhere).
@DaveCTurner DaveCTurner added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed Coordination Meta label for Distributed Coordination team test-arm Pull Requests that should be tested against arm agents labels Apr 25, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Apr 25, 2025
Merged
@nicktindall nicktindall self-requested a review April 28, 2025 06:13
@nicktindall nicktindall mentioned this pull request Apr 28, 2025
Closed
@elasticsearchmachine elasticsearchmachine merged commit 9e2ae4e into elastic:8.19 Apr 28, 2025
20 checks passed
@DaveCTurner DaveCTurner deleted the backport/8.x/pr-127372 branch April 28, 2025 07:34
@nicktindall nicktindall mentioned this pull request Apr 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicktindall nicktindall nicktindall approved these changes

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests test-arm Pull Requests that should be tested against arm agents v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DaveCTurner @nicktindall @elasticsearchmachine